This repository has been archived by the owner on Nov 13, 2024. It is now read-only.
Add defaults test #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed a few cases where it wasn't
igiloh-pinecone
force-pushed
the
add_defaults_test
branch
from
bf7c1d8 to
3b2321d
Compare
Since this test instantiates acutual objects (namely `OpenAILLM`), it needs to have actual API keys etc. This shouldn't be part of the unit tests
This involves doing an API call on __init__(), which is cumbersome. Worst case it will fail on the first LLm call
We removed this mechanism from the constructor
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We have two sets of defaults - one hard-coded in the code, and the other in a default config file.
Solution
Added a recursive test that verifies that a class instantiated with hard defaults is similar to class instantiated from default config.
Test Plan
Well...